Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[irrlicht] Fix build error under linux #41073

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jimwang118
Copy link
Contributor

One of the fixes for the #32398 issue.
The following error occurs when installing irrlicht[core,tools]:x64-linux.

/usr/bin/ld: /lib/x86_64-linux-gnu/libfontconfig.so.1: error adding symbols: DSO missing from command line
/mnt/vcpkg/buildtrees/irrlicht/src/irrlicht-1-633b25421b.clean/tools/IrrFontTool/newFontTool/CFontTool.cpp:407:(.text+0x102): undefined reference to `XftInitFtLibrary' 
/usr/include/X11/Xft/Xft.h:40:10: fatal error: ft2build.h: No such file or directory
   40 | #include <ft2build.h>
      |          ^~~~~~~~~~~~

Add tools feature to compile missing dependencies.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

The features passed with following triplets:

x64-windows
x64-linux

Usage test passed with following triplet:
x64-windows

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Sep 19, 2024
@jimwang118 jimwang118 marked this pull request as ready for review September 20, 2024 01:45
MonicaLiu0311
MonicaLiu0311 previously approved these changes Sep 20, 2024
@MonicaLiu0311 MonicaLiu0311 added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels Sep 20, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Sep 20, 2024

Where is the actual change? I only see whitespace changes.

@dg0yt
Copy link
Contributor

dg0yt commented Sep 20, 2024

Note that the original problem might be hard to solve in vcpkg at the moment:

Xft is a system lib, built with system freetype (shared objects). Mixing vcpkg freetype and system freetype is ... fragile at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants